Jump to content


Photo
- - - - -
Corner Case

Joined as sub but teams were full



  • Please log in to reply
7 replies to this topic

#1 Æsirson

Æsirson

    Member

  • Users
  • PipPip
  • 27 posts

Posted 30 May 2015 - 11:03 PM

TF2C Profile: Æsirson
Region: EU

Browser: Opera
Critical plugins: --
OS: Windows
Connection type: * Router

Bug type: In-game
Lobby ID: 427100
Date & Time: 31.5.2015 1:00 CET

After reporting himself Dr. Squid Phd kept on playing. I joined as a sub for him yet he wasn't kicked.
Another sub was kicked for being AFK before me.
Here are the logs for the game: http://logs.tf/846713
  • mariPr and Leslieseks like this

#2 Foxy

Foxy

    former dev

  • Members
  • PipPipPip
  • 995 posts

Posted 31 May 2015 - 11:07 AM

So the cause of this is:

 

1) Player 1 (blue spy) gets reported

2) Player 2 comes along, and takes the sub slot

3) Player 2 never joins, so gets reported

4) Player 3 (you) come along, and take the sub slot

5) Player 3 joins the server, but player 1 is still in that slot

 

Now, the problem exists because when player 2 joins the server, we would kick player 1 (the player that has been reported). However, as he never joins the server that doesn't happen, and so when you join we try to kick player 2 (the player that has been reported for your slot) but he's not on the server.

 

We can't just kick every substitute in history as they may have taken another slot in the lobby, but we could probably be kicking reported players as the sub slot is taken rather than when the target joins the server.



#3 ninjaMooCow

ninjaMooCow

    Former TF2C staff

  • Members
  • PipPipPipPipPip
  • 2225 posts
  • LocationOhio

Posted 31 May 2015 - 02:27 PM

Completing, as corner case.  Sorry, AE, looks like this is one of those situations that is really complicated to fix once you dig in.



#4 Æsirson

Æsirson

    Member

  • Users
  • PipPip
  • 27 posts

Posted 31 May 2015 - 04:07 PM

So if I were to rep myself and this bug occurs is it safe for me to leave? Would the sub get a ragequit if I didn't leave and he couldn't join therefore getting autorepped?



#5 Foxy

Foxy

    former dev

  • Members
  • PipPipPip
  • 995 posts

Posted 01 June 2015 - 10:24 PM

If you rep yourself you are safe to leave once the sub request has been taken. I can't guarantee what happens if you leave before that without taking a look at code. If sub couldn't join server/slot then yes, he would end up getting reported.



#6 Æsirson

Æsirson

    Member

  • Users
  • PipPip
  • 27 posts

Posted 02 June 2015 - 06:03 PM

Alright, thanks for clarifying.



#7 slayer

slayer

    Advanced Member

  • Members
  • PipPipPip
  • 136 posts

Steam Profile


   

Posted 03 June 2015 - 09:17 AM

This has happened to me several times.  I posted a bug report about it a while ago but I guess my post was deleted or something?

 

The other problem I've had that is similar (had it a few times also) is I go to join a sub slot and the server is full.  Because maybe it's a 6's server and has 12 or 13 slots (one for STV) and so the sub can not replace the other repped player.

 

The solution to that would be simple:  Donn't allow 6's servers with <14 slots, or HL with <20, which would allow one slot for a sub and one for an STV.



#8 Foxy

Foxy

    former dev

  • Members
  • PipPipPip
  • 995 posts

Posted 06 June 2015 - 01:53 PM

slayer: that should be handled already by reported players being kicked before you join. If that's not happening, give me some examples to look into 







Also tagged with one or more of these keywords: Corner Case

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users