Joined as sub but teams were full

TF2C Profile: Æsirson
Region: EU

Browser: Opera
Critical plugins: --
OS: Windows
Connection type: * Router

Bug type: In-game
Lobby ID: 427100
Date & Time: 31.5.2015 1:00 CET

After reporting himself Dr. Squid Phd kept on playing. I joined as a sub for him yet he wasn't kicked.
Another sub was kicked for being AFK before me.
Here are the logs for the game: http://logs.tf/846713

So the cause of this is:

 

1) Player 1 (blue spy) gets reported

2) Player 2 comes along, and takes the sub slot

3) Player 2 never joins, so gets reported

4) Player 3 (you) come along, and take the sub slot

5) Player 3 joins the server, but player 1 is still in that slot

 

Now, the problem exists because when player 2 joins the server, we would kick player 1 (the player that has been reported). However, as he never joins the server that doesn't happen, and so when you join we try to kick player 2 (the player that has been reported for your slot) but he's not on the server.

 

We can't just kick every substitute in history as they may have taken another slot in the lobby, but we could probably be kicking reported players as the sub slot is taken rather than when the target joins the server.

Completing, as corner case.  Sorry, AE, looks like this is one of those situations that is really complicated to fix once you dig in.

So if I were to rep myself and this bug occurs is it safe for me to leave? Would the sub get a ragequit if I didn't leave and he couldn't join therefore getting autorepped?

If you rep yourself you are safe to leave once the sub request has been taken. I can't guarantee what happens if you leave before that without taking a look at code. If sub couldn't join server/slot then yes, he would end up getting reported.

Alright, thanks for clarifying.

This has happened to me several times.  I posted a bug report about it a while ago but I guess my post was deleted or something?

 

The other problem I've had that is similar (had it a few times also) is I go to join a sub slot and the server is full.  Because maybe it's a 6's server and has 12 or 13 slots (one for STV) and so the sub can not replace the other repped player.

 

The solution to that would be simple:  Donn't allow 6's servers with <14 slots, or HL with <20, which would allow one slot for a sub and one for an STV.

slayer: that should be handled already by reported players being kicked before you join. If that's not happening, give me some examples to look into