Jump to content


Photo
- - - - -
Completed

XSS vuln in lobby chat



  • This topic is locked This topic is locked
4 replies to this topic

#1 Furl

Furl

    Newbie

  • Users
  • Pip
  • 2 posts

Posted 01 June 2014 - 06:05 PM

http://i.imgur.com/GCTE1gb.png

 

meow :3

 



#2 TheMattgician

TheMattgician

    Supreme Poster Overlord

  • Members
  • PipPipPipPipPip
  • 1210 posts

Posted 01 June 2014 - 06:54 PM

Your image doesn't seem to work. Could you update it?


  • loop likes this

#3 Furl

Furl

    Newbie

  • Users
  • Pip
  • 2 posts

Posted 01 June 2014 - 08:25 PM

Ah, whatever.  I'll just explain it fully:

 

When chats are sent from the server dynamically (ie via websocket, not as part of initial page load), usernames aren't escaped.  So if you set your steam username to e.g. `<script>alert('xss')` and then send a message on a lobby chat or on the global chat, everyone that has that page loaded will have that javascript executed when they receive the message.



#4 TheMattgician

TheMattgician

    Supreme Poster Overlord

  • Members
  • PipPipPipPipPip
  • 1210 posts

Posted 01 June 2014 - 08:41 PM

Alright, the devs noticed. It should be fixed tomorrow.

Thanks for reporting



#5 Foxy

Foxy

    former dev

  • Members
  • PipPipPip
  • 995 posts

Steam Profile

Posted 01 June 2014 - 10:43 PM

Thanks for pointing this out Furl :)

 

I've hidden this topic until deploy goes out, since this is quite an exploitable bug


Fixed :)







Also tagged with one or more of these keywords: Completed